Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] App ID needed? #819

Closed
cibersheep opened this issue Feb 5, 2022 · 5 comments
Closed

[UT] App ID needed? #819

cibersheep opened this issue Feb 5, 2022 · 5 comments
Milestone

Comments

@cibersheep
Copy link
Contributor

I need to verify if this parameter is still needed but it might make life easier :)

By memory, I think --app-id=[appname.appdev] is needed to handle .cache and .local files accordantly

https://docs.ubports.com/en/latest/appdev/webapp/guide.html#command-line-arguments

@cibersheep
Copy link
Contributor Author

Mhm, you have set up the app name as "ubports-little-webapp"

https://github.com/kiwix/kiwix-js/blob/master/ubuntu_touch/manifest.json#L10

Maybe this can be address in the future:

  • the webapp is not from UBports (the foundation) so it shouldn't be in the app id
  • more conventional app id should be something like kiwix.kiwixteam for example. Changing this will break compatibility from older app versions (and may need to be published as a 'new' app in the Open Store

@cibersheep
Copy link
Contributor Author

Confirmed, the cache files are stored under ~/.cache/kiwix but the manifest is specifies ubports-little-webapp
this might cause the app loos the cache files on restart

@cibersheep
Copy link
Contributor Author

I have updated the manisfest: #827

but I think the name parameter needs to be updated to name.organisation format. This might be not needed and will make OpenStore force to create a "new app" due to the change of the name.

Do you want me to update or wait?

@mossroy
Copy link
Contributor

mossroy commented Feb 8, 2022

The problem of a "new app" is that previous users will not automatically be upgraded.
As we currently have a regression that needs to be fixed, I would hold this update for now, and discuss it later

@cibersheep
Copy link
Contributor Author

Perfect. Thank you

@Jaifroid Jaifroid added this to the v3.3 milestone Feb 9, 2022
@mossroy mossroy modified the milestones: v3.3, v3.3.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants