Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest for UT #827

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Update manifest for UT #827

merged 2 commits into from
Feb 8, 2022

Conversation

cibersheep
Copy link
Contributor

  • Name of the app in title in capital letters
  • Updated description (It might have been too short)
  • Update name hook (it may break updates if the app was installed before, it needs to be checked)

@cibersheep cibersheep mentioned this pull request Feb 6, 2022
@mossroy
Copy link
Contributor

mossroy commented Feb 8, 2022

OK for me on these changes, if they are tested on UT

ubuntu_touch/manifest.json Outdated Show resolved Hide resolved
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, other than possibly finessing the description if @mossroy agrees.

Copy link
Contributor

@mossroy mossroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the wording remark of @Jaifroid
Else it's fine for me

@mossroy mossroy mentioned this pull request Feb 8, 2022
18 tasks
@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2022

Before we squash/merge, could I just check what you found out about this potentially breaking updates for those who have the app already? I mean, they will probably have uninstalled it by now because it's broken, but there's a small risk of people being left with an orphaned app they think will never work again, and they don't try out the new one.

But this is more "your" platform than ours, so I trust your judgement on the type of users it has. I guess they're likely to be independent-minded people who will proactively check if an app they need isn't working....

@cibersheep
Copy link
Contributor Author

With this change it might be needed to delete the cache. Not a major problem, I would say.
I think, UT users are quite used to do that anyway, and yep, look for help :)

@Jaifroid Jaifroid merged commit a318835 into kiwix:master Feb 8, 2022
@Jaifroid Jaifroid added this to the v3.3 milestone Feb 9, 2022
@mossroy mossroy modified the milestones: v3.3, v3.3.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants