-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest for UT #827
Conversation
cibersheep
commented
Feb 6, 2022
- Name of the app in title in capital letters
- Updated description (It might have been too short)
- Update name hook (it may break updates if the app was installed before, it needs to be checked)
OK for me on these changes, if they are tested on UT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, other than possibly finessing the description if @mossroy agrees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the wording remark of @Jaifroid
Else it's fine for me
Before we squash/merge, could I just check what you found out about this potentially breaking updates for those who have the app already? I mean, they will probably have uninstalled it by now because it's broken, but there's a small risk of people being left with an orphaned app they think will never work again, and they don't try out the new one. But this is more "your" platform than ours, so I trust your judgement on the type of users it has. I guess they're likely to be independent-minded people who will proactively check if an app they need isn't working.... |
With this change it might be needed to delete the cache. Not a major problem, I would say. |