Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.7.0 #943

Closed
26 tasks done
Jaifroid opened this issue Dec 22, 2022 · 12 comments
Closed
26 tasks done

Release 3.7.0 #943

Jaifroid opened this issue Dec 22, 2022 · 12 comments
Assignees
Labels
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Dec 22, 2022

Although we had a release relatively recently (for this Repo), I feel that full-text search is a biggie and worth a relatively early release (post festivities).

@Jaifroid Jaifroid added the task label Dec 22, 2022
@Jaifroid Jaifroid self-assigned this Dec 22, 2022
@kelson42 kelson42 added this to the v3.7 milestone Dec 22, 2022
@Jaifroid Jaifroid modified the milestones: v3.7, v3.8 Jan 3, 2023
@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 3, 2023

@kelson42 After I've finished the final tests and merged the CHANGELOG PR (see checkboxes above), are you happy for me to publish this release?

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 3, 2023

Manual tests completed. Everything appears to be working as planned.

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 4, 2023

@kelson42 The unsigned version of the Chrome extension is here. Could you kindly upload to the Chrome store, for which I don't have the credentials? I'll do the Edge, Firefox and Ubuntu Touch stores.

@kelson42
Copy link
Collaborator

kelson42 commented Jan 4, 2023

@Jaifroid Chrome extension is under review and have uploaded new version to https://download.kiwix.org/release/browsers/chrome/kiwix-chrome_3.7.0.crx.

We have to notice that 3.7.0 is 10x bigger than before and is now around 5MB compressed.

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 4, 2023

@kelson42 Yes, this is due to the new libzim binary. What happened is that the dev version, which is unminified, got included in the final release, which I wasn't aware of. The Firefox submission complained about this, so I deleted the dev versions and resubmitted, and it was accepted.

I'll make an issue to add code to remove the dev versions from packaged apps for future versions. Is this sufficient, or would you prefer to have the unsigned extension without the dev binaries, and resubmit package before the Chrome review is approved? I have a version from which I've deleted those files now, and can upload if necessary. On the other hand, a 5MB download for the update is not enormous for most users, compared to typical app sizes nowadays.

Let me know what you think.

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 4, 2023

Issue created: #953.

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 4, 2023

Having merged the PR fixing #953, I re-ran the build script from GitHub Actions, which has automatically updated the release files for firefox-os and ubuntu-click (on https://download.kiwix.org/release/), so they are now a more acceptable size, though still a bit larger than before due to the new (minified) libzim binaries.

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 4, 2023

Just waiting for the Chrome and Edge stores to update now before publicizing this version.

@kelson42
Copy link
Collaborator

kelson42 commented Jan 5, 2023

@Jaifroid I think we are all good?!

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 5, 2023

Although the Edge Store entry is updated, it still seems to be serving version 3.6..., or at least mine is not updating despite refreshes, etc. Not sure how long the underlying database takes to update...

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 5, 2023

I spoke too soon, it's just updated to 3.7. So we're good to go. I'll do some publicity on reddit and mastodon (a bit later today).

@Jaifroid
Copy link
Member Author

Jaifroid commented Jan 5, 2023

Done!

@Jaifroid Jaifroid closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants