Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy developer versions of libzim binaries into final release packages #953

Closed
Jaifroid opened this issue Jan 4, 2023 · 0 comments · Fixed by #954
Closed

Do not copy developer versions of libzim binaries into final release packages #953

Jaifroid opened this issue Jan 4, 2023 · 0 comments · Fixed by #954
Assignees
Labels
build Code relating to building, publishing, or maintaining the app
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jan 4, 2023

The packaging scripts copy all the code under www into final release packages. Unfortunately, developer version of the libzim binaries, which are necessary to work with, therefore got included in version 3.7.0. One of these in particular, the JS ASM version, is very large due to all the comments in the unminified version. This increased the app size by a factor of 10, unnecessarily, since the file will never be read by the app.

The Firefox store complained about this, so I removed the offending files. I did the same for the Edge Store submission.

The packaging app needs to exclude explicitly any files marked as dev, before the next release is prepared.

@Jaifroid Jaifroid added the build Code relating to building, publishing, or maintaining the app label Jan 4, 2023
@Jaifroid Jaifroid added this to the v3.8 milestone Jan 4, 2023
@Jaifroid Jaifroid self-assigned this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building, publishing, or maintaining the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant