Make jQuery routines into functions and eliminate unhandled exception #348 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossroy
approved these changes
Mar 20, 2018
|
In fact, the issue with Chrome on file:// was already open : #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've organized all the jQuery routines into functions. I thought it best to leave these functions within the scope of displayArticleInForm, not because it's necessary, but because it's neater, I think. Let me know if you would prefer them to be in global scope. I've tested on FFOS and the functions work fine in this scope.
I've disabled the loadJavaScriptJQuery function to prevent overhead until it is worked on. However, I've fixed the line that was causing an unhandled exception as per #348.
Tested and working in: Firefox ERS, FFOS, Edge and Internet Explorer. Please test in Chrome if you can.