Executed changes suggested by codefactor #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
requested changes
Oct 22, 2020
There was a problem hiding this comment.
@ram690514 Most of this looks good, but please see comments for needed changes.
|
Additionally, please rename this PR to something more informative, like "Implement changes suggested by codefactor". |
|
@Jaifroid . I updated the pull request .please check it |
|
@ram690514 please answer the review comments and questions left here in the review. |
|
@ram690514 I'm trying to get the automated tests to run against your PR. Please be patient. |
|
Okay
…On Thu, Oct 22, 2020 at 6:49 PM Jaifroid ***@***.***> wrote:
@ram690514 <https://github.com/ram690514> I'm trying to get the automated
tests to run against your PR. Please be patient.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#663 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAWVBWARVNJJ5NYSDM672LSMAWOVANCNFSM4S2XLKJQ>
.
|
Jaifroid
reviewed
Oct 22, 2020
|
I will restore it
…On Fri, Oct 23, 2020 at 12:28 AM Jaifroid ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In www/js/app.js
<#663 (comment)>:
> @@ -490,7 +490,6 @@ define(['jquery', 'zimArchiveLoader', 'uiUtil', 'settingsStore','abstractFilesys
tmpMessageChannel.port1.onmessage = handleMessageChannelMessage;
// Send the init message to the ServiceWorker, with this MessageChannel as a parameter
navigator.serviceWorker.controller.postMessage({'action': 'init'}, [tmpMessageChannel.port2]);
- messageChannel = tmpMessageChannel;
OK, while this does not seem to be needed in Chromium, I don't think it's
safe to remove this line without extensive testing, because it is part of a
"keepalive" implementation. The SW API may well have been fixed in recent
times, but we can't be sure users do not have old browsers, so please
restore this line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#663 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAWVBRIZ7XYXXIHRNTVQSDSMB6GTANCNFSM4S2XLKJQ>
.
|
|
@ram690514 Travis CI has been broken, this is not ready to review. |
|
OK, tests are now passing. |
Jaifroid
reviewed
Oct 24, 2020
|
@ jaifroid : I will surely work on it . Thank you
…On Sat, Oct 24, 2020, 7:48 PM Jaifroid ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In www/js/app.js
<#663 (comment)>:
> @@ -514,7 +514,7 @@ define(['jquery', 'zimArchiveLoader', 'uiUtil', 'settingsStore','abstractFilesys
// So we have to disable it manually (even if it's still registered and active)
navigator.serviceWorker.controller.postMessage({'action': 'disable'});
messageChannel = null;
- }
+ }
@ram690514 <https://github.com/ram690514> It's minor, but there are two
added space here that should be removed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#663 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAWVBQHLATEW7J2OA6G3U3SMLO45ANCNFSM4S2XLKJQ>
.
|
|
@ram690514 Any feedback? |
Jaifroid
approved these changes
Nov 7, 2020
|
@mossroy Are you happy for this simple PR to be squashed and merged? |
mossroy
approved these changes
Nov 7, 2020
|
OK, except the typo on "avaialbale" |
|
OK, thanks. I need a better keyboard :-( ! |
|
Codefactor score on master before merge is C-. I doubt it'll change much with these few edits. Let's see. Squashing and merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.