tests: Remove redundant xzdec.js include #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows-up 0c53010, which removed this from www/index.html, but it was still present in the test suite. This is now loaded automatically by RequireJS.
Jaifroid
approved these changes
Nov 22, 2020
|
@Krinkle I think there is no obstacle to your merging this simple PR? |
Thanks, I wasn't sure what the workflow was meant to be. Most projects I've contributed to have the reviewer perform the merge act, so I figured maybe you or Kelson wanted to do that later. To confirm, after seeing approval from one of you, I should feel free to merge my own PR? |
|
@Krinkle I think for complex PRs we would probably want two devs to approve, but for something this straightforward one would be fine. But yes, once approved the author of the PR usually squashes and merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows-up 0c53010, which removed this from www/index.html, but it was still present in the test suite.
This is now loaded automatically by RequireJS.
/cc @Jaifroid per https://github.com/kiwix/kiwix-js/pull/672/files/20229d190570f25a1bbed0353881579a394be221#r528327775
This supersedes the fork-PR at #675.