Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning on each start when ServiceWorker is not supported #815

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Fix warning on each start when ServiceWorker is not supported #815

merged 1 commit into from
Feb 5, 2022

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented Feb 4, 2022

Fixes #814

@mossroy mossroy requested a review from Jaifroid February 4, 2022 12:58
Jaifroid
Jaifroid approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging this! Pesky parentheses....

@mossroy mossroy merged commit 05db48d into master Feb 5, 2022
@mossroy mossroy deleted the fix-warning-on-each-start-when-SW-not-supported branch February 5, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaifroid Jaifroid Jaifroid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On some devices that do not support ServiceWorkers, a warning is displayed on every run
2 participants
@mossroy @Jaifroid