-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UT icon and splash updated #818
Conversation
The reason the test has failed is because we need to exempt |
Whatever works best for the platform in this case. Be aware that some users will be using the app in dark mode. If there is a lot of white and a small amount of black, it can be quite harsh or jarring if using an app at night. |
Oh, I can do that. Sorry
Well spotted. I can do some mockups and you can decide. I was going for «official look» but I also get flashed by white backgrounds :D |
This is the old logo, the logo has the circle nearer to the feets. See https://commons.wikimedia.org/wiki/File:Kiwix_logo_v3.svg |
Personally I'd prefer the slightly darker background bottom left because of not getting blinded if opening the app at night (as mentioned above). Regarding the new logo, is this the right one, @kelson42? - https://github.com/kiwix/kiwix-js-windows/blob/master/www/img/icons/favicon-270x270.png Is there a better source with SVG for example? I think I grabbed that one form the kiwix.org web site. |
Oops. Sorry, I didn't check. I'll update it
Then I'll go with darker grey. This is something we can change later :) |
I'll review when @cibersheep will have updated the icon |
Ok. I have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not test, but the icons look good and this PR is harmless
OK. @cibersheep are you happy for us to squash/merge now? |
Warp 9! |
I think the official colors for the app are black on white, right?
Should fix #817