Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT icon and splash updated #818

Merged
merged 4 commits into from
Feb 8, 2022
Merged

UT icon and splash updated #818

merged 4 commits into from
Feb 8, 2022

Conversation

cibersheep
Copy link
Contributor

  • Added svg icon
  • Edited UT/desktop file to use svg and white background on the splash

I think the official colors for the app are black on white, right?

Should fix #817

@Jaifroid
Copy link
Member

Jaifroid commented Feb 5, 2022

The reason the test has failed is because we need to exempt kiwix_scalable.svg from the files that are required by the PWA version, which is currently not relevant to Ubuntu touch. If you add this file to $ListOfExemptions in https://github.com/kiwix/kiwix-js/blob/master/scripts/Check-OfflineFilesList.ps1 , then the test-offline-files test should succeed.

@Jaifroid
Copy link
Member

Jaifroid commented Feb 5, 2022

I think the official colors for the app are black on white, right?

Whatever works best for the platform in this case. Be aware that some users will be using the app in dark mode. If there is a lot of white and a small amount of black, it can be quite harsh or jarring if using an app at night.

@cibersheep
Copy link
Contributor Author

cibersheep commented Feb 5, 2022

The reason the test has failed is because [...]

Oh, I can do that. Sorry

Be aware that some users will be using the app in dark mode.

Well spotted. I can do some mockups and you can decide. I was going for «official look» but I also get flashed by white backgrounds :D

@cibersheep
Copy link
Contributor Author

cibersheep commented Feb 5, 2022

I'll do the changes now, but in the meantime. Something like this?
imatge
imatge imatge

@kelson42
Copy link
Collaborator

kelson42 commented Feb 6, 2022

This is the old logo, the logo has the circle nearer to the feets. See https://commons.wikimedia.org/wiki/File:Kiwix_logo_v3.svg

@Jaifroid
Copy link
Member

Jaifroid commented Feb 6, 2022

Personally I'd prefer the slightly darker background bottom left because of not getting blinded if opening the app at night (as mentioned above).

Regarding the new logo, is this the right one, @kelson42? -

https://github.com/kiwix/kiwix-js-windows/blob/master/www/img/icons/favicon-270x270.png

Is there a better source with SVG for example? I think I grabbed that one form the kiwix.org web site.

@kelson42 kelson42 added this to the v3.4 milestone Feb 6, 2022
@cibersheep
Copy link
Contributor Author

This is the old logo, the logo has the circle nearer to the feets. See https://commons.wikimedia.org/wiki/File:Kiwix_logo_v3.svg

Oops. Sorry, I didn't check. I'll update it

Personally I'd prefer the slightly darker background bottom left because of not getting blinded if opening the app at night (as mentioned above).

Then I'll go with darker grey. This is something we can change later :)

@Jaifroid Jaifroid self-requested a review February 6, 2022 16:22
@Jaifroid Jaifroid requested a review from mossroy February 6, 2022 16:23
@mossroy
Copy link
Contributor

mossroy commented Feb 6, 2022

I'll review when @cibersheep will have updated the icon

@cibersheep
Copy link
Contributor Author

I'll review when @cibersheep will have updated the icon

Ok. I have:

  • Updated the icon to the last version :)
  • Added a splash image
  • Tweaked the desktop file: add the dark grey to the splash, use the splash image and deleted the "translation" for enUS (I guess it was showing "kiwix.desktop" as the name of the app

Copy link
Contributor

@mossroy mossroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test, but the icons look good and this PR is harmless

@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2022

OK. @cibersheep are you happy for us to squash/merge now?

@mossroy mossroy mentioned this pull request Feb 8, 2022
18 tasks
@cibersheep
Copy link
Contributor Author

Warp 9!

@Jaifroid Jaifroid merged commit 7808453 into kiwix:master Feb 8, 2022
@Jaifroid Jaifroid modified the milestones: v3.4, v3.3 Feb 9, 2022
@mossroy mossroy modified the milestones: v3.3, v3.3.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UT] App icon doesn't follow UT design guidelines
4 participants