-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in publish extension workflow and add logging #829
Conversation
I decided to move the script that replaces the version numbers in the app from the Workflow (where it is difficult to maintain and test) into a bash script in /scripts. This runs correctly in a WSL bash, tested on Windows 10 Debian shell. I have tested the workflow by publishing a test version to gh-pages using the manual workflow dispatch. I got this result. Hopefully the logging is more informative now. NB this did not publish to Docker, only to our test implementation on gh-pages. |
To test it yourself, ensure you run the workflow dispatch from the branch Please note that there is a difference between the version number that we put in the files and that is displayed to the user, and the value that will be used as the docker push tag. The docker push tag is actually irrelevant to us, the user will never see it. But it is significant if we are releasing a tag.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test but the code looks good.
I've only made some minor remarks.
Co-authored-by: Mossroy <[email protected]>
Latest regexp changes tested via test workflow, to ghpages, setting a release number of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK you can merge
This should fix #823.
@mossroy Kindly check the bash script statements carefully with your "Linux glasses" on! I'm not very familiar with it. If it can be simplified, happy to do so.
I will create a quick test script (copy of the rewrite script in the workflow) with some sample input to be sure the rewriting works, and will test in WSL on Windows.