Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Enter key in Bootstrap modal dialogs #864

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Handle Enter key in Bootstrap modal dialogs #864

merged 2 commits into from
Jun 1, 2022

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented May 31, 2022

Fixes #863

@mossroy mossroy requested a review from Jaifroid May 31, 2022 15:04
Jaifroid
Jaifroid reviewed May 31, 2022
View reviewed changes
www/js/lib/uiUtil.js Outdated Show resolved Hide resolved
Jaifroid
Jaifroid approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Jaifroid Jaifroid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, and it works. I may be wrong about keyup vs keydown.

PS Tested in Chromium (Edge) and IE11 mode.

@Jaifroid
Copy link
Member

Jaifroid commented Jun 1, 2022

I tested the native DOM code in IE11. Working fine. I think it can be merged.

@mossroy mossroy merged commit a57d622 into master Jun 1, 2022
@mossroy mossroy deleted the enter-key-in-bootstrap-modals branch June 1, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaifroid Jaifroid Jaifroid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap dialog boxes should handle a default action with Enter key
2 participants
@mossroy @Jaifroid