-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PWA in Firefox extension when SW API is unavailable #878
Conversation
Switched this PR to draft as it's not working properly for now |
Now tested on Firefox 103.0 on Ubuntu |
Thanks for this PR. I'll test the UX (by installing as a developer-mode extension). I wonder if there is another way of preventing users of old Firefox editions (I mean really old ones that don't support Service Worker at all) from being invited to switch to SW mode? Is this a case where testing explicitly for (Firefox < 103 AND SW unavailable) is warranted? Or could we test for a proxy API that will assure us that we are in a recent Firefox? |
After fighting to disable auto-update of Firefox, I managed to test with version 52.9.0ESR. So it's not that bad. If we want to test the browser version, it should only be a "hint", like adding in the systemAlert that it will probably not work because this browser probably does not support ServiceWorkers. But we should avoid making a decision based on this version |
OK, that's good. I think it's enough for now. We might have to introduce something once we switch to SW mode as default (assuming we will apply that default to the Firefox extension version). I've tested on:
So I don't think I need to do any more tests. I'll take a look at the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Just one small coding-style suggestion below. When you're happy you've done enough testing, feel free to squash/merge.
This is necessary for Firefox >=103, where the ServiceWorker API has been removed in WebExtensions. See https://hg.mozilla.org/integration/autoland/rev/3a2907ad88e8 Fixes #877
d827c85
to
452fc0d
Compare
This is necessary for Firefox >=103, where the ServiceWorker API has been removed in WebExtensions.
See https://hg.mozilla.org/integration/autoland/rev/3a2907ad88e8
Fixes #877