Converts jQuery statements to native JS and regularize quotation marks

[dheerajdlalwani]

Should potentially fix #920

I have converted as many jQuery functions as I could to native JS.

[Jaifroid]

Thank you very much @dheerajdlalwani. This is looking very good. Just some small comments/queries, and some suggestions to make parts more concise. I haven't tested yet.

[Jaifroid]

Thank you, nearly there pending some minor changes suggested below. I'll do some manual testing.

[Jaifroid]

All good, many thanks! I'll let you know when I've been able to complete tests. Were you able to test in IE11, for example scrolling to top with and without a ZIM archive loaded?

[dheerajdlalwani]

All good, many thanks! I'll let you know when I've been able to complete tests. Were you able to test in IE11, for example scrolling to top with and without a ZIM archive loaded?

I was able to test this in IE 11 with the Zim archive loaded.
I certainly did not test it without loading the Zim archive.
I shall get on to it and perhaps do some more testing.
Thank you!

[Jaifroid]

OK, thanks! I meant just to test if the scroll to top button (on bottom bar) doesn't produce an exception in console if there is no archive loaded.

[dheerajdlalwani]

OK, thanks! I meant just to test if the scroll to top button (on bottom bar) doesn't produce an exception in console if there is no archive loaded.

Yup, I understood what you meant. And no, it does not give an exception. I checked and tested.

[Jaifroid]

In IE11, articles appear to load, but then don't display correctly. It works fine in Edge Chromium. Can you reproduce?

[Jaifroid]

Same problem when running the app in IE Mode in Edge Chromium.

[Jaifroid]

It's something to do with the slide transitions. If you turn the transitions off in Configuration, you can see that the page loads in IE11 and then slides away. A transition is being applied incorrectly it seems. Can you debug?

[Jaifroid]

Please debug display of articles in IE11, looking carefully at the slide transition code in uiutil.js. Test it with the transitions turned on and also with them turned off. 😎

[dheerajdlalwani]

Oooh yes, I shall get on to it. This seems interesting!

[Jaifroid]

Great that you found a solution! Just one last minor suggestion to make the code more concise.

[Jaifroid]

I confirm it now works in IE11. 🙂

[Jaifroid]

There seem to be some problems in the Firefox OS simulator. I'll try to debug these. It's not really evident what this is, but the app appears unresponsive even though no exceptions are being thrown.

[Jaifroid]

@dheerajdlalwani It turns out that Firefox OS does not recognize the word let, which is the reason we have always used var in this project (oddly, I wasn't aware of this before!).

Although Firefox OS is now deprecated, we still try to keep support "if it's not too complicated". I've tested replacing let with var wherever you used let , with a search-and-replace in my IDE, and it allows the Firefox OS app to work again.

Would you prefer to make this change this yourself, or would you like me to make a commit to your PR? It's completely up to you.

NB you still have to check one-by-one that you aren't changing let in comments, etc., if you use global search-and-replace. And also, please don't change any let that appear in files that are not part of this PR (e.g. in service-worker.js), as these files are not read by Firefox OS and we use modern code there.

In the future, we hope to implement #554 and Babel, and then it will be possible to write modern code and compile for earlier browsers.

[dheerajdlalwani]

@dheerajdlalwani It turns out that Firefox OS does not recognize the word let, which is the reason we have always used var in this project (oddly, I wasn't aware of this before!).

Although Firefox OS is now deprecated, we still try to keep support "if it's not too complicated". I've tested replacing let with var wherever you used let , with a search-and-replace in my IDE, and it allows the Firefox OS app to work again.

Would you prefer to make this change this yourself, or would you like me to make a commit to your PR? It's completely up to you.

NB you still have to check one-by-one that you aren't changing let in comments, etc., if you use global search-and-replace. And also, please don't change any let that appear in files that are not part of this PR (e.g. in service-worker.js), as these files are not read by Firefox OS and we use modern code there.

In the future, we hope to implement #554 and Babel, and then it will be possible to write modern code and compile for earlier browsers.

Oh, I didn't know this. I shall fix this right away.

[Jaifroid]

This is now working in the Firefox OS simulator. Many thanks.

[Jaifroid]

@dheerajdlalwani Let me know when you're happy for this to be squashed/merged.

[dheerajdlalwani]

This looks good to me! Go ahead and squash and merge it.