fixup! Handling of <dc:issued> in OPDS import

kiwix · Feb 22, 2022 · f8da503 · f8da503
1 parent e6412b9
commit f8da503
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/book.cpp b/src/book.cpp
@@ -161,7 +161,9 @@ void Book::updateFromOpds(const pugi::xml_node& node, const std::string& urlHost
   m_language = VALUE("language");
   m_creator = node.child("author").child("name").child_value();
   m_publisher = node.child("publisher").child("name").child_value();
-  m_date = fromOpdsDate(VALUE("dc:issued"));
+  const std::string dcIssuedDate = VALUE("dc:issued");
+  m_date = dcIssuedDate.empty() ? VALUE("updated") : dcIssuedDate;
+  m_date = fromOpdsDate(m_date);
   m_name = VALUE("name");
   m_flavour = VALUE("flavour");
   m_tags = VALUE("tags");

diff --git a/test/library.cpp b/test/library.cpp
@@ -273,7 +273,7 @@ TEST(LibraryOpdsImportTest, allInOne)
   EXPECT_EQ(book2.getName(), "");
   EXPECT_EQ(book2.getFlavour(), "");
   EXPECT_EQ(book2.getLanguage(), "eng");
-  EXPECT_EQ(book2.getDate(), "");
+  EXPECT_EQ(book2.getDate(), "2018-07-23");
   EXPECT_EQ(book2.getDescription(), "Ideas worth spreading");
   EXPECT_EQ(book2.getCreator(), "TED");
   EXPECT_EQ(book2.getPublisher(), "");