Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #314 from kiwix/trust_library #314

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

mgautierfr
Copy link
Member

Do not try to read the zim file and update the book when parsing a
library.xml.
Needed by kiwix/kiwix-tools#319

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #314 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #314      +/-   ##
=========================================
+ Coverage    13.6%   13.6%   +<.01%     
=========================================
  Files          44      44              
  Lines        3419    3418       -1     
  Branches     2032    2031       -1     
=========================================
  Hits          465     465              
+ Misses       2540    2539       -1     
  Partials      414     414
Impacted Files Coverage Δ
include/manager.h 77.77% <ø> (ø) ⬆️
src/manager.cpp 26.85% <0%> (+0.48%) ⬆️
src/book.cpp 49.59% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f990fe...34257cf. Read the comment docs.

mgautierfr added a commit to kiwix/kiwix-tools that referenced this pull request Jan 30, 2020
Now `kiwix-serve` trust the information in the library.xml.
We do not open all zim file at startup and so kiwix-serve starts faster.

Need kiwix/libkiwix#314
Fix #319
Do not try to read the zim file and update the book when parsing a
library.xml.
Needed by kiwix/kiwix-tools#319
@mgautierfr mgautierfr changed the title Trust the library.xml information by default. Merge pull request #314 from kiwix/trust_library Jan 30, 2020
@mgautierfr mgautierfr merged commit d14ba0c into master Jan 30, 2020
@mgautierfr mgautierfr deleted the trust_library branch January 30, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant