-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized kiwix-serve welcome page #714
Conversation
@kelson42 can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankur12-1610 Thank you for your PR. It indeed works better now, but I'm not really happy with the solution because there is still an asymetry between the left and the right. The tiles should maximize the space usage and be distributed in the middle horizontaly. So the whole block of the book list should be centered horizontally.
@kelson42 got it. So the current padding is |
@kelson42 I've made the required changes kindly review :) |
@ankur12-1610 This is getting better, but it seems not propoer for all screens. See here, it is not centered properly |
@ankur12-1610 Any news on this PR? |
Hey @kelson42 sorry for the late reply I'm working on it and will update the PR by a day or two :') |
@ankur12-1610 thx! |
@kelson42 I did the changes, although in a little unorthodox way 😅, by testing every float value :) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Superseeded by #786 |
Fixes: kiwix-tools/#538
Before:
![153743002-48e1f36a-d9a6-43a6-83f6-93532dab6150](https://user-images.githubusercontent.com/76884959/154480134-83d12f04-5ada-493f-b4bb-bae51377f6f2.png)
After:
![kiwix-media](https://user-images.githubusercontent.com/76884959/154480197-57f2d038-3438-4445-a1fe-8ea2a0d26fcc.png)