Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized kiwix-serve welcome page #714

Closed
wants to merge 2 commits into from
Closed

Optimized kiwix-serve welcome page #714

wants to merge 2 commits into from

Conversation

ankur12-1610
Copy link

Fixes: kiwix-tools/#538

Before:
153743002-48e1f36a-d9a6-43a6-83f6-93532dab6150

After:
kiwix-media

@ankur12-1610
Copy link
Author

@kelson42 can you please review?

@kelson42 kelson42 requested review from kelson42 and rgaudin February 17, 2022 16:21
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankur12-1610 Thank you for your PR. It indeed works better now, but I'm not really happy with the solution because there is still an asymetry between the left and the right. The tiles should maximize the space usage and be distributed in the middle horizontaly. So the whole block of the book list should be centered horizontally.

@ankur12-1610
Copy link
Author

@ankur12-1610 Thank you for your PR. It indeed works better now, but I'm not really happy with the solution because there is still an asymetry between the left and the right. The tiles should maximize the space usage and be distributed in the middle horizontaly. So the whole block of the book list should be centered horizontally.

@kelson42 got it. So the current padding is 20px 5vw 20px 10vw, the soultion whould be that I change it to 20px 5vw 20px 5vw right?

@ankur12-1610
Copy link
Author

@kelson42 I've made the required changes kindly review :)

@kelson42
Copy link
Collaborator

@ankur12-1610 This is getting better, but it seems not propoer for all screens. See here, it is not centered properly
image

@kelson42
Copy link
Collaborator

@ankur12-1610 Any news on this PR?

@ankur12-1610
Copy link
Author

ankur12-1610 commented Mar 20, 2022

Hey @kelson42 sorry for the late reply

I'm working on it and will update the PR by a day or two :')

@kelson42
Copy link
Collaborator

@ankur12-1610 thx!

@ankur12-1610
Copy link
Author

@kelson42 I did the changes, although in a little unorthodox way 😅, by testing every float value :)

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot removed the stale label Jul 3, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@kelson42
Copy link
Collaborator

Superseeded by #786

@kelson42 kelson42 closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiwix-serve welcome page not optimised
2 participants