Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country name to view #105

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Conversation

itsniper
Copy link
Contributor

Great library and almost perfect for what I needed. My need was for a country picker for a sign-up form so additionally, I needed the full country name in the view. Added this as an additional flag that can be set. Also, updated the demo app and README accordingly. Hope this can be helpful for someone else as well. Cheers!

@itsniper
Copy link
Contributor Author

Oh yes ... I also fixed an auto-layout issue in the demo app where "SEARCH BAR POSITION" was getting clipped vertically.

@kizitonwose
Copy link
Owner

Thank you very much for contributing. I like the name addition although, in the current logic, it will be shown only if the country and phone code properties are set to false. I think we can have it in such a way that country name and code and dependent on each other. That is, if code is enabled, name is disabled and vice versa. This way, if a user really wants, they can have [Flag][Name][Phone code] on the view.

I'll just merge this and make the "if-else" changes needed in the dev branch.

Once again, thank you!

@kizitonwose kizitonwose merged commit c9b436b into kizitonwose:dev Feb 22, 2020
@kizitonwose
Copy link
Owner

Now available in 3.0.9 🚀

@itsniper
Copy link
Contributor Author

I like that idea 👍. I'm happy to contribute to a well-maintained library, and I appreciate the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants