Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix error regression from 10.4.1 #527

Merged
merged 1 commit into from
Nov 24, 2021
Merged

try to fix error regression from 10.4.1 #527

merged 1 commit into from
Nov 24, 2021

Conversation

topce
Copy link
Contributor

@topce topce commented Nov 24, 2021

error loading discovery document ReferenceError: assignment to undeclared variable hPub
generateKeyPairHex jsrsasign.js:235
generateKeypair jsrsasign.js:238
load key-store.service.ts:37

error loading discovery document ReferenceError: assignment to undeclared variable hPub
    generateKeyPairHex jsrsasign.js:235
    generateKeypair jsrsasign.js:238
    load key-store.service.ts:37
@kjur kjur merged commit dd7a376 into kjur:master Nov 24, 2021
@kjur
Copy link
Owner

kjur commented Nov 24, 2021

Hi @topce , thank you for your PR.

@topce topce deleted the patch-1 branch November 25, 2021 05:51
@topce
Copy link
Contributor Author

topce commented Nov 25, 2021

Welcome ;-)
Thank you for great library !
Is it possible to publish 10.5.1 to npm?

@kjur
Copy link
Owner

kjur commented Nov 25, 2021

I may wait PRs for #526 and #525 if possible.

@topce
Copy link
Contributor Author

topce commented Nov 25, 2021

no problem
thank you!

@kjur
Copy link
Owner

kjur commented Dec 1, 2021

Hi @topce , I've released 10.5.1 with your PR today. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants