Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey @kklas - thanks for taking the time to write and maintain this library, it's really useful.
This pull request migrates
anchor-client-gen
to@solana/web3.js
v2.0.Solana web3.js 2.0 is now recommended for general use.
The official anchor repo will take some time to migrate.
Features
Address
borsh deserializer to handle new typeFooStruct.pubkey_field
to testpubkey
+types
serializationIssues
buffer-layout
dependencyUnfortunately the new
Address
type requires a borsh helper to unpack with, this is not yet provided by@coral-xyz/borsh
.The result is that
anchor-client-gen
users now have a direct dependency onbuffer-layout
. Hopefully this can be removed in the future.mut
There is an outstanding bug with optional accounts where the placeholder program address is marked as writable.
Compiling these transactions fails with the new sdk. This should be fixed separately, draft PR here.