-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canvas as dependency. #36
Conversation
Hi @DeviousM, |
Hi! Sorry, this is actually a bit more complex as canvas as a dependency is sooo fucked up that as you can see I'm currently trying to figure out why is it so bad. The thing is that when it's running the newest version it's doing this on the SSR:
|
Yes, I agree, the way JSDOM requires/includes Canvas is not straightforward. Good luck with your debug/investigation! Let me know if I can help with anything. |
Unfortunately I was not able to make it work, dependencies were all too tangled up for me to resolve them properly and I was not able to make it work in an SSR environment as it ended up blowing up in my face on every attempt. |
As JSDOM requires
canvas
as a dependency while creating a production build, we need it as a dependency (as JSDOM has it as a peer dependency).