Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render attribution text using innerHTML property. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adeschamps
Copy link
Contributor

This makes it possible to use attributions that have links in them.

I considered whether attributes should be Html msg instead of String, but it seems like tile sources are often accompanied by a snippet of HTML for you to copy-paste. On the other hand, this approach doesn't really allow you to style the attribution, so maybe Html msg is the way to go.

This makes it possible to use attributions that have links in them.
@klaftertief
Copy link
Owner

I did not want to have it Html msg because I wanted to limit the number of allowed elements. To support links I head the idea to use a proper type for the attribution that allowed either just a String or a String with a URL or a combination of both. But adding plain Html and an Html as String makes also sense. Will think about the preferred way a bit. Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants