Deprecate Go 1.21 and add 1.24 #1055
Conversation
Remove old docs, prep for new release.
📝 WalkthroughWalkthroughThe changes update the CI configurations, module declarations, changelog documentation, and test output formatting. In the GitHub Actions workflows, the Go versions have been revised—jobs in the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (11)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
30-38: New Changelog Entries for Release 1.18.0
New changelog entries have been added for the Feb 19th, 2025 release ([1.18.0]). The bullet points clearly list the improvements and fixes introduced in this update.Consider revising the formatting of the URLs in these entries. For example, adopting markdown link syntax (e.g.,
[description](URL)) or wrapping bare URLs in angle brackets (<...>) can improve readability and help satisfy markdown linting rules (MD034).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
31-31: Bare URL used
null(MD034, no-bare-urls)
32-32: Bare URL used
null(MD034, no-bare-urls)
33-33: Bare URL used
null(MD034, no-bare-urls)
34-34: Bare URL used
null(MD034, no-bare-urls)
35-35: Bare URL used
null(MD034, no-bare-urls)
36-36: Bare URL used
null(MD034, no-bare-urls)
37-37: Bare URL used
null(MD034, no-bare-urls)
594-602: Markdown Formatting Consistency
Static analysis indicates several markdown formatting issues (bare URLs, unordered list indentation, and hard tabs). It would be beneficial to standardize the markdown formatting throughout the document to improve consistency and readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/go.yml(6 hunks).github/workflows/release.yml(1 hunks)README.md(8 hunks)fse/fse_test.go(2 hunks)go.mod(1 hunks)s2sx.mod(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- s2sx.mod
- go.mod
- fse/fse_test.go
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
31-31: Bare URL used
null
(MD034, no-bare-urls)
32-32: Bare URL used
null
(MD034, no-bare-urls)
33-33: Bare URL used
null
(MD034, no-bare-urls)
34-34: Bare URL used
null
(MD034, no-bare-urls)
35-35: Bare URL used
null
(MD034, no-bare-urls)
36-36: Bare URL used
null
(MD034, no-bare-urls)
37-37: Bare URL used
null
(MD034, no-bare-urls)
40-40: Bare URL used
null
(MD034, no-bare-urls)
41-41: Bare URL used
null
(MD034, no-bare-urls)
42-42: Bare URL used
null
(MD034, no-bare-urls)
43-43: Bare URL used
null
(MD034, no-bare-urls)
94-94: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
94-94: Hard tabs
Column: 1
(MD010, no-hard-tabs)
94-94: Bare URL used
null
(MD034, no-bare-urls)
95-95: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
95-95: Hard tabs
Column: 1
(MD010, no-hard-tabs)
95-95: Bare URL used
null
(MD034, no-bare-urls)
96-96: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
96-96: Hard tabs
Column: 1
(MD010, no-hard-tabs)
96-96: Bare URL used
null
(MD034, no-bare-urls)
153-153: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
153-153: Hard tabs
Column: 1
(MD010, no-hard-tabs)
153-153: Bare URL used
null
(MD034, no-bare-urls)
196-196: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
196-196: Hard tabs
Column: 1
(MD010, no-hard-tabs)
196-196: Bare URL used
null
(MD034, no-bare-urls)
238-238: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
238-238: Hard tabs
Column: 1
(MD010, no-hard-tabs)
238-238: Bare URL used
null
(MD034, no-bare-urls)
265-265: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
265-265: Hard tabs
Column: 1
(MD010, no-hard-tabs)
266-266: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
266-266: Hard tabs
Column: 1
(MD010, no-hard-tabs)
267-267: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
267-267: Hard tabs
Column: 1
(MD010, no-hard-tabs)
268-268: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
268-268: Hard tabs
Column: 1
(MD010, no-hard-tabs)
269-269: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
269-269: Hard tabs
Column: 1
(MD010, no-hard-tabs)
270-270: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
270-270: Hard tabs
Column: 1
(MD010, no-hard-tabs)
287-287: Unordered list indentation
Expected: 2; Actual: 1
(MD007, ul-indent)
287-287: Hard tabs
Column: 1
(MD010, no-hard-tabs)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: build (1.24.x, windows-latest)
- GitHub Check: build (1.24.x, macos-latest)
- GitHub Check: build (1.24.x, ubuntu-latest)
- GitHub Check: build (1.23.x, windows-latest)
- GitHub Check: build (1.23.x, macos-latest)
- GitHub Check: fuzz-zstd ("noasm,nounsafe")
- GitHub Check: build (1.23.x, ubuntu-latest)
- GitHub Check: fuzz-zstd (nounsafe)
- GitHub Check: fuzz-s2 ("noasm,nounsafe")
- GitHub Check: build (1.22.x, windows-latest)
- GitHub Check: fuzz-s2 (nounsafe)
- GitHub Check: build (1.22.x, macos-latest)
- GitHub Check: fuzz-other ("noasm,nounsafe")
- GitHub Check: build (1.22.x, ubuntu-latest)
- GitHub Check: fuzz-other (nounsafe)
🔇 Additional comments (7)
.github/workflows/release.yml (1)
22-25: Update Go Version for GoReleaser Setup
Thego-versionin the actions/setup-go step is updated to1.24.x, which aligns with the project's new supported Go version. This change ensures that the release workflow uses the latest version as outlined in the PR objectives..github/workflows/go.yml (6)
14-16: Update Go-Version Matrix in Build Job
The Go version matrix is modified to remove the deprecated1.21.xand add1.24.x. This update ensures that the build process tests against the supported range:1.22.x, 1.23.x, 1.24.x.
61-64: Set Go Version in Generate Job
The generate job now specifiesgo-version: 1.24.x, which is consistent with the new version support.
83-86: Update Go Version in Build-Special Job
The build-special job’s setup has been updated to use Go version1.24.x, supporting the overall CI shift to the latest version.
126-129: Update Go Version in Fuzz-S2 Job
The fuzz-s2 job has been updated withgo-version: 1.24.x, aligning the fuzz tests with the new Go version requirement.
152-155: Update Go Version in Fuzz-Zstd Job
Thego-versionin the fuzz-zstd job is now set to1.24.x, ensuring that tests for the zstd package run on the current supported Go version.
183-186: Update Go Version in Fuzz-Other Job
The fuzz-other job also usesgo-version: 1.24.xnow, maintaining consistency across all CI jobs regarding the Go version used.
Remove old docs, prep for new release.
Summary by CodeRabbit
Documentation
Chores