Never return negative values from Write, as they can panic in bufio
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
May 15, 2020
Co-authored-by: Klaus Post <[email protected]>
|
Thanks for the contribution. I will make a new release. |
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
May 15, 2020
This upgrades pgzip to include a [fix](klauspost/pgzip#33) to prevent negative byte counts being returned from `pgzip.Write`, which cause panics in `bufio`. These panics manifest when using compressed xtrabackup backups as: ``` Error: <_Rendezvous of RPC that terminated with (StatusCode.UNKNOWN, caught panic during Backup: bufio: writer returned negative count from Write)> ``` Signed-off-by: Andrew Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32.