This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 184
Remove KIR/PoC and introduce KCF/KFF from API returns and internal code #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
requested review from
ethan-kr,
jeongkyun-oh,
blukat29 and
ian0371
as code owners
February 24, 2023 11:53
aidan-kwon
force-pushed
the
230204-apiKgfKir
branch
from
February 24, 2023 11:55
d793557
to
080a5e7
Compare
No need to add hard fork logic? |
|
blukat29
reviewed
Feb 27, 2023
blukat29
reviewed
Feb 27, 2023
blukat29
reviewed
Feb 27, 2023
aidan-kwon
force-pushed
the
230204-apiKgfKir
branch
from
February 27, 2023 01:47
6c49f4f
to
62b5009
Compare
0xxlegolas
previously approved these changes
Feb 27, 2023
praveen-kaia
previously approved these changes
Feb 27, 2023
Closed
aidan-kwon
dismissed stale reviews from praveen-kaia and 0xxlegolas
via
February 27, 2023 04:13
2ec33b8
This change affects to only two APIs that is not widely used. So, I just make a change and announce it by publishing an interface KIP. |
I introduced a JSON marshal method to provide backward compatibility |
ian0371
reviewed
Feb 27, 2023
kjeom
approved these changes
Feb 27, 2023
blukat29
approved these changes
Feb 27, 2023
ian0371
approved these changes
Feb 27, 2023
ethan-kr
approved these changes
Feb 27, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is a part of KGP-6 implementation, however, it causes a change in the API return format.
klay_getRewards
APIBefore
After
klay_getStakingInfo
API.This change also affects to StakingInfo data stored in database, so the unmarshal function of StakingInfo is added to support both legacy data and new data.
Before
After
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)