Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

ci: reduce coverage test failures #2113

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

yoomee1313
Copy link
Contributor

@yoomee1313 yoomee1313 commented Feb 15, 2024

The sequential execution time of coverage is about 43m, so 60m time limit would be enough.
In the future, if it exceeds 60m, we can still double up. Or we can fix some tests which are allocated ports. (console tests, randao fork tests, etc)

Proposed changes

  • Describe your changes to communicate to the maintainers why we should accept this pull request.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

- make coverage test sequential and double the time limit for the test
- remove TestDiffLayer failure
@yoomee1313 yoomee1313 force-pushed the mitigate-coverage-test branch 2 times, most recently from 90efd07 to f2e50f2 Compare February 15, 2024 07:05
@klaytn klaytn deleted a comment from codecov-commenter Feb 15, 2024
@yoomee1313 yoomee1313 marked this pull request as ready for review February 16, 2024 01:48
Copy link
Contributor

@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yoomee1313 yoomee1313 merged commit c20c2ad into klaytn:dev Feb 22, 2024
11 checks passed
@yoomee1313 yoomee1313 deleted the mitigate-coverage-test branch February 22, 2024 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants