This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
ethers: Webpack bundle and browser-html example #552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
force-pushed
the
ethers/browser-bundle
branch
from
December 15, 2023 06:29
fda66be
to
848b32f
Compare
blukat29
force-pushed
the
ethers/browser-bundle
branch
from
December 15, 2023 10:25
ca329ab
to
679265e
Compare
blukat29
force-pushed
the
ethers/browser-bundle
branch
from
December 17, 2023 10:37
679265e
to
ce61540
Compare
blukat29
force-pushed
the
ethers/browser-bundle
branch
from
December 17, 2023 12:07
ce61540
to
66f6540
Compare
blukat29
requested review from
kjeom,
nohkwak and
JayChoi1736
as code owners
December 18, 2023 10:16
kjeom
approved these changes
Dec 18, 2023
@kjeom It would be great if Kaikas accepted numeric types (8) but currently, Kaikas only accepts string upper snake case (VALUE_TRANSFER) types. But apart from Kaikas accepting numeric types, ethers-ext will use the string types for maximum compatibility. I believe Kaikas will continue accepting the string types, for both dApp & SDK (i.e. caver) backward compatibility. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web3Provider extends ethers.Web3Provider
JsonRpcSigner implements ethers.JsonRpcSigner