Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

ethers: Webpack bundle and browser-html example #552

Merged
merged 34 commits into from
Dec 19, 2023

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Dec 3, 2023

  • Additional ethers extension types
    • Web3Provider extends ethers.Web3Provider
    • JsonRpcSigner implements ethers.JsonRpcSigner
  • Kaikas wallet support
     const provider = new Web3Provider(window.klaytn);
     const signer = provider.getSigner();
     const address = await signer.getAddress();
     const txhash = await signer.sendTransaction({ type: 8, from: address, to: address, value: 0 });
  • Internal refactoring

@blukat29 blukat29 force-pushed the ethers/browser-bundle branch from fda66be to 848b32f Compare December 15, 2023 06:29
@blukat29 blukat29 force-pushed the ethers/browser-bundle branch from ca329ab to 679265e Compare December 15, 2023 10:25
@blukat29 blukat29 force-pushed the ethers/browser-bundle branch from 679265e to ce61540 Compare December 17, 2023 10:37
@blukat29 blukat29 force-pushed the ethers/browser-bundle branch from ce61540 to 66f6540 Compare December 17, 2023 12:07
@blukat29 blukat29 marked this pull request as ready for review December 18, 2023 10:16
@blukat29
Copy link
Contributor Author

@nohkwak @kjeom PR ready.

@kjeom
Copy link
Member

kjeom commented Dec 18, 2023

@blukat29 @nohkwak It looks like having the type transform layer. It doesn't need to develop the feature in the Kaikas?

@blukat29
Copy link
Contributor Author

@kjeom It would be great if Kaikas accepted numeric types (8) but currently, Kaikas only accepts string upper snake case (VALUE_TRANSFER) types.

But apart from Kaikas accepting numeric types, ethers-ext will use the string types for maximum compatibility. I believe Kaikas will continue accepting the string types, for both dApp & SDK (i.e. caver) backward compatibility.

@blukat29 blukat29 merged commit 189551a into klaytn:dev Dec 19, 2023
@blukat29 blukat29 deleted the ethers/browser-bundle branch December 19, 2023 01:28
@kjeom kjeom mentioned this pull request Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants