Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StoreChangeBehavior] Store change should only update the modified node #1417

Merged
merged 1 commit into from
Jul 20, 2017
Merged

[StoreChangeBehavior] Store change should only update the modified node #1417

merged 1 commit into from
Jul 20, 2017

Conversation

c3dr0x
Copy link
Contributor

@c3dr0x c3dr0x commented Jul 13, 2017 •
edited
Loading

Fix issue #1404

Description

If a store is udpated then the store-behavior execute the getStateFromStore and updates all listened nodes in state.

Patch

When the onChange callback is called, a list of nodes' name is passed down to the getStateFromStore to pick only the updated node.

@c3dr0x c3dr0x added this to the 2.2.0 milestone Jul 13, 2017
@c3dr0x c3dr0x self-assigned this Jul 13, 2017
@c3dr0x c3dr0x requested a review from Hartorn July 13, 2017 14:57
@c3dr0x c3dr0x changed the title [StoreChangeBehavior] Store change should only update the modified note [StoreChangeBehavior] Store change should only update the modified node Jul 17, 2017
@Hartorn
Copy link
Contributor

Hartorn commented Jul 20, 2017

@c3dr0x Could be nice to have some UT on that, but it works fine :)

Hartorn
Hartorn approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, some unit testing and it would be perfect

@Hartorn Hartorn merged commit 599eca9 into develop Jul 20, 2017
@Hartorn Hartorn deleted the fix-store-updateNode branch July 20, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartorn Hartorn Hartorn approved these changes

Assignees

@c3dr0x c3dr0x

Labels
Bug Release Note Review OK Waiting for Release
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@c3dr0x @Hartorn