Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking on item in book #275

Closed
DaFuqs opened this issue Dec 30, 2024 · 2 comments
Closed

Crash when clicking on item in book #275

DaFuqs opened this issue Dec 30, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DaFuqs
Copy link
Contributor

DaFuqs commented Dec 30, 2024

Original issue: DaFuqs/Spectrum#650
Reposting it here since when looking at the crashlog it's a ModonomiconJeiIntegration issue.

Describe the bug
Clicking on a vanilla item with EMI+JEI installed will crash the game.

Description: mouseClicked event handler

java.lang.NullPointerException: Cannot invoke "mezz.jei.api.runtime.IJeiRuntime.getJeiHelpers()" because "com.klikli_dev.modonomicon.integration.ModonomiconJeiIntegration$ModonomiconJeiPlugin.jeiRuntime" is null
	at knot//com.klikli_dev.modonomicon.integration.ModonomiconJeiIntegration$ModonomiconJeiHelper.showRecipe(ModonomiconJeiIntegration.java:60)
	at knot//com.klikli_dev.modonomicon.integration.ModonomiconJeiIntegration.showRecipe(ModonomiconJeiIntegration.java:44)
	at knot//com.klikli_dev.modonomicon.client.gui.book.BookContentScreen.method_25430(BookContentScreen.java:726)
	at knot//com.klikli_dev.modonomicon.client.gui.book.BookContentScreen.method_25402(BookContentScreen.java:793)
	at knot//net.minecraft.class_312.method_1611(class_312.java:98)
	at knot//net.minecraft.class_437.method_25412(class_437.java:409)
	at knot//net.minecraft.class_312.method_1601(class_312.java:98)
	at knot//net.minecraft.class_312.method_22686(class_312.java:169)
	at knot//net.minecraft.class_1255.execute(class_1255.java:102)
	at knot//net.minecraft.class_312.method_22684(class_312.java:169)
	at knot//org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at knot//org.lwjgl.system.JNI.invokeV(Native Method)
	at knot//org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403)
	at knot//com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:201)
	at knot//com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:219)
	at knot//net.minecraft.class_1041.method_15998(class_1041.java:288)
	at knot//net.minecraft.class_310.method_1523(class_310.java:1241)
	at knot//net.minecraft.class_310.method_1514(class_310.java:802)
	at knot//net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

To Reproduce
Open the Colorful World book, find an entry where a vanilla item is mentioned (for example: mud dipping four-leaf clover into a scute) and click the said item (in this case, the highlighted text mentioning the scute).

Expected behavior
Not a crash, obviously.

System (please complete the following information):

  • Modloader: Fabric
  • Modonomicon Version: 1.77.3
  • Minecraft Version: 1.20.1

Additional context
Crash Log

@DaFuqs DaFuqs added the bug Something isn't working label Dec 30, 2024
@klikli-dev
Copy link
Owner

Thanks for reporting!

Out of interest, does it NOT crash if a modded item is clicked??

@DaFuqs
Copy link
Contributor Author

DaFuqs commented Dec 30, 2024

I have not tested it myself, but I assume the player that reported it just wanted to point at that is even happens for "non modded" items, so I assume all items will crash 😄

If you want to I can test it out tomorrow

klikli-dev added a commit that referenced this issue Dec 31, 2024
klikli-dev added a commit that referenced this issue Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants