Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iesnium highlight not visible #864

Closed
enimog opened this issue Dec 17, 2022 · 5 comments
Closed

Iesnium highlight not visible #864

enimog opened this issue Dec 17, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@enimog
Copy link

enimog commented Dec 17, 2022

Hello, it's not possible to mine iesnium because it is not visible when using the divination rod. Reverting ccb6a03 (for 1.45.1) and recompiling from the latest commit fix the issue. Possible conflict with #788 ?

@enimog enimog added the bug Something isn't working label Dec 17, 2022
@klikli-dev
Copy link
Owner

Thanks for the report, and thanks for testing the revert!
I will have to investigate - I changed it to the new rendering after a recommendation in the forge discord, because the old rendering did not work for at least one person.

@klikli-dev
Copy link
Owner

The issue does not reproduce for me in dev or in a clean install via CF.
I am going to try and find more people with the issue to collect data & inquire in the forge discord for a solution that works for both the group that now has issues & the people that had issues with the old rendering

@enimog
Copy link
Author

enimog commented Dec 18, 2022

Maybe it has something to do with video drivers? Me and a friend both have the issue, but we are both using an AMD card. The person from #788 is using an NVIDIA card. In any case, I'm sorry to hear that you can't reproduce it on your side... I'd be very happy to test builds from you if you need it.

@klikli-dev
Copy link
Owner

@enimog after talking to the good people in the forge discord two suggestions have come up:

  1. For you: Please verify you are on the latest AMD driver version for your card. There have been render issues with recent driver versions that are resolved on latest
  2. For me: Moving the overlay rendering into a different render target - rendering it after particles, which I will implement presently

@klikli-dev
Copy link
Owner

v1.19.2-1.57.4 contains the changes - please ping me here if the issue persists after

klikli-dev added a commit that referenced this issue Dec 19, 2022
Also switch to using vanilla to build block outline to avoid duplicate code

See also #864 (but that issue never existed on 1.18.2)
klikli-dev added a commit that referenced this issue Dec 19, 2022
Also switch to using vanilla to build block outline to avoid duplicate code

Closes #864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants