Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom Spirit Names being addition to the random pool, instead of a forced override #895

Closed
Kanzaji opened this issue Feb 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Kanzaji
Copy link
Contributor

Kanzaji commented Feb 16, 2023

Feature Description

Add a way to specify a chance for pre-defined names, instead of a random one, with 1 being full override and 0 pre-defined names disabled.

Why I would like that Feature?

Custom Spirit Names are for now just an override, what is a bit problematic for modpack makers, because you have to come up with a lot of names to have good variety of them, like it is with Random 😅 This would be great for just adding like 10 names to the pool as an eastereggs or just to have few that people could say "Hey I recognize that guy" 😄

@Kanzaji Kanzaji added the enhancement New feature or request label Feb 16, 2023
@Kanzaji Kanzaji changed the title [Feature Request] Custom Spirit Names being addition to the random pool, and not an override [Feature Request] Custom Spirit Names being addition to the random pool, instead of a forced override Feb 16, 2023
klikli-dev added a commit that referenced this issue Feb 17, 2023
- Allow custom spirit names alongside random generated ones ("usePossibleSpiritNamesChance")
- Extend generation algorithm with more syllables for grater name variety

Closes #895
klikli-dev added a commit that referenced this issue Feb 17, 2023
- Allow custom spirit names alongside random generated ones ("usePossibleSpiritNamesChance")
- Extend generation algorithm with more syllables for grater name variety

Closes #895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant