Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable adding familiar rings to loot tables #915

Closed
klikli-dev opened this issue Apr 24, 2023 · 3 comments
Closed

Enable adding familiar rings to loot tables #915

klikli-dev opened this issue Apr 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@klikli-dev
Copy link
Owner

See also #907

Motoko in Discord:

I know apotheosis/placebo does this. For instance, we were callilng apotheosis:affix_entry in e6 to add apotheosis drops to some loot tables: https://github.com/EnigmaticaModpacks/Enigmatica6/blob/01bcfb55a9dbe7290850702c22511429cf9e19cc/kubejs/server_scripts/enigmatica/kubejs/base/loot_tables/apotheosis/tome_tower.js#L133
So I suppose it'd be a matter of adding a custom function to call your random name generator
@klikli-dev klikli-dev added the enhancement New feature or request label Apr 24, 2023
@klikli-dev
Copy link
Owner Author

@MuteTiefling @theboo pinging you, I created an issue out of our discord conversation.

Will research how to do that once I find a bit of time

@MuteTiefling
Copy link
Contributor

Nice, thanks!

@MuteTiefling
Copy link
Contributor

Some thoughts on potential default adds to loot tables:

Shipwrecks: Cthulhu
Small Dungeons: Bat/greedy
Villages: Crow/Parrot depending on location
Desert Temple: Fairy
End Cities: Beholder
Bastion: Devil

klikli-dev added a commit that referenced this issue Apr 26, 2023
@klikli-dev
feat: enable familiar rings to auto-initialize when spawned from nbt
8e4e6a8 
This allows to create working familiar rings e.g. via commands or loot tables 

Closes #915
klikli-dev added a commit that referenced this issue Apr 26, 2023
@klikli-dev
feat: enable familiar rings to auto-initialize when spawned from nbt
924c5be 
This allows to create working familiar rings e.g. via commands or loot tables 

Closes #915
klikli-dev added a commit that referenced this issue Apr 26, 2023
@klikli-dev
feat: enable familiar rings to auto-initialize when spawned from nbt
5d647b7 
This allows to create working familiar rings e.g. via commands or loot tables 

Closes #915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MuteTiefling @klikli-dev