Fix for Demon's Dream Seeds dropping while using Modded Shears #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Why I made a PR instead of the issue? |
Kanzaji
changed the title
|
Oops! That of course should always have been a tag! |
klikli-dev
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Update datura_seed_from_tall_grass.json * Update datura_seed_from_grass.json Thanks @Kanzaji Co-authored-by: Kanzaji <[email protected]>
klikli-dev
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Update datura_seed_from_tall_grass.json * Update datura_seed_from_grass.json Thanks @Kanzaji Co-authored-by: Kanzaji <[email protected]>
|
Oh and separate PRs for the other versions are not necessary as I can cherry-pick the commit over onto the other versions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beware!
This does also affect 1.18.2 version of the mod (and probably 1.19.1 and 1.19.3, 😅) So not sure if this PR is enough, or I should make few more with those changes on other branches. Just let me know if you want me to do so 😄
Issue Description
Modded shears with tag "#forge:shears" just doesn't exactly work because of the way loot_modifiers are made, what causes Demon's Dream seeds to drop while using them 😅
Fix Description
Change out predicate to use Tag instead of Items, so modded Shears can work without issues 😄
I've tested this fix on 1.18.2 and 1.19.2 versions of the mod! Seems to be working fine.