Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit hashとかを奥付に入れる。 #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

commit hashとかを奥付に入れる。 #33

wants to merge 3 commits into from
+13 −2

Conversation

nna774
Copy link
Member

@nna774 nna774 commented Sep 9, 2023

Image from Gyazo

#30 を実現。

@nna774 nna774 requested a review from hanazuki September 9, 2023 02:05
@hanazuki
Copy link
Member

hanazuki commented Sep 9, 2023

リリース版にも表示したいかな？（しなくていいと思う）
リリース版で消す場合，奥付のデザインに影響しないようにページのマージンとかに表示するほうがいいとおもう．

@nna774
Copy link
Member Author

nna774 commented Sep 9, 2023 •
edited
Loading

リリース版にも入れてもいいのかなー とぼんやり思ってたけど、入れない時はこのファイルを空にすれば空のincludeでよいかな？ とかぼんやり思ってた。でもたしかにマージンとかに毎ページ出すほうがよいのかも？(どうやるんだ？)

wass88
wass88 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@wass88 wass88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby依存が元からあるなら良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass88 wass88 wass88 approved these changes

@hanazuki hanazuki Awaiting requested review from hanazuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nna774 @hanazuki @wass88