Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter unused authz #1166

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Filter unused authz #1166

merged 3 commits into from
Jan 9, 2025

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Jan 8, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1162

Currently istiod does not support pushing only local authorizations.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Zhonghu Xu <[email protected]>
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.88%. Comparing base (ff82786) to head (1230553).
Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/workload_processor.go 77.27% 3 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
pkg/controller/workload/workload_processor.go 62.07% <77.27%> (+0.93%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0def8...1230553. Read the comment docs.

@hzxuzhonghu
Copy link
Member Author

/retest

return err
}
if workload.Node == p.nodeName {
p.deleteWorkloadPolicies(backendUid)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Don't you have to check if there are any policies here?
Just like before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@LiZhenCheng9527
Copy link
Collaborator

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit d8c0539 into kmesh-net:main Jan 9, 2025
12 checks passed
@hzxuzhonghu hzxuzhonghu deleted the filter-authz branch January 9, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not store non local workloads' authorization
3 participants