implemented unit testing of log package #1234
Closed
+141
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @harshitghagre! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
|
@harshitghagre First of all, thanks for your contribution! I guess this PR and #1226 implement same function? I think you could do something hasn't assigned yet, like E2E for log? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a test/unit PR that adds unit tests for the logging functionality.
What this PR does / why we need it:
This PR implements unit tests for the
logspackage, ensuring that the logging functionality behaves as expected. Unit tests are crucial for catching regressions and maintaining code quality, especially for critical components like logging.Which issue(s) this PR fixes:
Fixes #1226 (Implement log unit tests).
Special notes for your reviewer:
GetLoggerNamesandSetLoggerLevelfunctions.Does this PR introduce a user-facing change?:
No, this PR does not introduce any user-facing changes.