Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for catalog & images in Galactic coordinates #46

Open
kmhess opened this issue May 2, 2022 · 3 comments
Open

Allow for catalog & images in Galactic coordinates #46

kmhess opened this issue May 2, 2022 · 3 comments

Comments

@kmhess
Copy link
Owner

kmhess commented May 2, 2022

Currently SIP only deals with data in equatorial (RA/Dec) coordinates. Expand to accept & properly plot data in Galactic coords (l, b).
@kmhess
Copy link
Owner Author

kmhess commented May 6, 2022

Some progress has been made (not yet uploaded to github) by testing on products made with SoFiA 2.4.0, but fails on mom1 for unknown reasons, and needs checking with pv plot and spec plot using SoFiA 2.4.1 output.

kmhess pushed a commit that referenced this issue May 8, 2022
Allow l,b to be passed from catalog to submodules #46
4971329
kmhess pushed a commit that referenced this issue May 8, 2022
Add SkyView retrieval based on galactic coordinates #46
d7e09c8
kmhess pushed a commit that referenced this issue May 8, 2022
Generalize plotting to include ra/dec or galactic #46
8e75e50
kmhess pushed a commit that referenced this issue May 8, 2022
Abstract plotting labels to function #46.
27bb6c2
@kmhess
Copy link
Owner Author

kmhess commented May 11, 2022

New capabilities added in Release 1.1.0, however testing still needs to be done with output generated by the latest version of SoFiA.

kmhess pushed a commit that referenced this issue Jun 6, 2022
Generalize create_pv to work with Gal coords #46
93d298e
kmhess pushed a commit that referenced this issue Jun 6, 2022
Work around for plotting kinpa on mom1 in Gal coord #46
686114a
@kmhess
Copy link
Owner Author

kmhess commented Jun 6, 2022 •
edited
Loading

For some unknown reason, for the one data set I have in Galactic coords, ax.annotate and fig.savefig do not play nice together, so I use a regular ax.plt to plot the kinematic position angle, but it doesn't have an arrowhead. I think nearly everything else works for the case of Galactic coordinates.
https://github.com/kmhess/SoFiA-image-pipeline/blob/686114a2e680acaa7e9ded0343e596e7ca1b8223/src/make_images.py#L402-#L409

@kmhess kmhess mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmhess