Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster-local-gateway. #411

Conversation

JRBANCEL
Copy link
Contributor

Part 3 of #237 (comment).

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #411 (5428830) into master (eaf3680) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   81.17%   81.37%   +0.19%     
==========================================
  Files          15       15              
  Lines        1004     1004              
==========================================
+ Hits          815      817       +2     
+ Misses        110      109       -1     
+ Partials       79       78       -1     
Impacted Files Coverage Δ
pkg/reconciler/ingress/ingress.go 66.16% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf3680...5428830. Read the comment docs.

@JRBANCEL
Copy link
Contributor Author

/retest

1 similar comment
@JRBANCEL
Copy link
Contributor Author

/retest

@JRBANCEL JRBANCEL changed the title [WIP] Remove cluster-local-gateway. Remove cluster-local-gateway. Nov 17, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2020
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 058432d into knative-extensions:master Nov 18, 2020
knative-prow-robot pushed a commit to knative/docs that referenced this pull request Feb 26, 2021
knative-extensions/net-istio#411 replaced cluster-local-gateway with knative-local-gateway.
Hence this patch updates the docs.
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
knative-extensions/net-istio#411 replaced cluster-local-gateway with knative-local-gateway.
Hence this patch updates the docs.
yangyunfeng007 pushed a commit to yangyunfeng007/docs that referenced this pull request Mar 8, 2021
knative-extensions/net-istio#411 replaced cluster-local-gateway with knative-local-gateway.
Hence this patch updates the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants