Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --scale-activation flag to match new Serving option #1729

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Add --scale-activation flag to match new Serving option #1729

merged 4 commits into from
Sep 5, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Aug 26, 2022 •
edited by dsimansk
Loading

Description

Add --scale-activation flag to match new Serving option

Changes

  • Added the flag
  • Added unit and e2e tests

Reference

Fixes #1713

Release Note

Add `--scale-activation` flag to `service create` command options

knative-prow[bot]
knative-prow bot reviewed Aug 26, 2022
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Add --scale-activation flag to match new Serving option

Changes

  • Added the flag
  • Added unit and e2e tests

Reference

Fixes #1713

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2022
@vyasgun vyasgun force-pushed the pr/scale-activation branch from 610594f to 1a4b026 Compare August 26, 2022 14:50
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2022
@vyasgun vyasgun force-pushed the pr/scale-activation branch from 1a4b026 to fa07315 Compare August 26, 2022 14:51
@codecov
Copy link

codecov bot commented Aug 26, 2022 •
edited
Loading

Codecov Report

Merging #1729 (ab372bb) into main (76b3724) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   79.90%   79.93%   +0.02%     
==========================================
  Files         174      174              
  Lines       13529    13540      +11     
==========================================
+ Hits        10811    10823      +12     
- Misses       1979     1980       +1     
+ Partials      739      737       -2
Impacted Files Coverage Δ
pkg/serving/config_changes.go 95.20% <0.00%> (-1.55%) ⬇️
...kg/kn/commands/service/configuration_edit_flags.go 83.24% <100.00%> (+0.28%) ⬆️
pkg/kn/commands/flags/sink.go 86.13% <0.00%> (+3.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vyasgun
Copy link
Contributor Author

vyasgun commented Aug 26, 2022

/retest

1 similar comment
@vyasgun
Copy link
Contributor Author

vyasgun commented Aug 28, 2022

/retest

dsimansk
dsimansk reviewed Aug 29, 2022
View reviewed changes
test/e2e/service_test.go Outdated Show resolved Hide resolved
dsimansk
dsimansk previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one suggestion for e2e test location. Otherwise looks good, thanks!

Edit: sorry that should have been change-request not approved. :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@dsimansk dsimansk removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@dsimansk dsimansk dismissed their stale review August 29, 2022 14:13

Misclick

dsimansk
dsimansk requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one suggestion for e2e test location. Otherwise looks good, thanks!

@vyasgun vyasgun force-pushed the pr/scale-activation branch from a3f9f90 to ab372bb Compare September 2, 2022 08:56
@dsimansk dsimansk added the kind/feature New feature or request label Sep 5, 2022
dsimansk
dsimansk approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6376f9a into knative:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@dsimansk dsimansk dsimansk approved these changes

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature New feature or request lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --scale-activation flag to match new Serving option
2 participants
@vyasgun @dsimansk