[release-1.11] Fixed eventtype create-delete loop on built in sources (#7245) #7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed eventtype create-delete loop on built in sources Signed-off-by: Calum Murray <[email protected]> * Fix unit tests Signed-off-by: Calum Murray <[email protected]> * Fixed source finalizers Signed-off-by: Calum Murray <[email protected]> * Fixed tests Signed-off-by: Calum Murray <[email protected]> --------- Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
the
area/test-and-release
|
/cc @matzew |
knative-prow
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #7250 +/- ##
================================================
- Coverage 77.74% 77.66% -0.08%
================================================
Files 250 250
Lines 13506 13519 +13
================================================
Hits 10500 10500
- Misses 2470 2482 +12
- Partials 536 537 +1
☔ View full report in Codecov by Sentry. |
matzew
changed the title
dsimansk
pushed a commit
to dsimansk/eventing
that referenced
this pull request
Jan 12, 2024
…knative#7250) * Fixed eventtype create-delete loop on built in sources * Fix unit tests * Fixed source finalizers * Fixed tests --------- Signed-off-by: Calum Murray <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 12, 2024
…knative#7250) (#491) * Fixed eventtype create-delete loop on built in sources * Fix unit tests * Fixed source finalizers * Fixed tests --------- Signed-off-by: Calum Murray <[email protected]> Co-authored-by: Calum Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry pick of #7245