Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audience description for remaining CRDs #7493

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Dec 6, 2023

Similar to #7482. There were a few more CRDs that needed fixes.

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot requested review from aliok and odacremolbap December 6, 2023 08:22
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ee2699) 76.12% compared to head (7c2dd15) 76.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7493   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files         260      260           
  Lines       14467    14467           
=======================================
  Hits        11013    11013           
  Misses       2888     2888           
  Partials      566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur
Copy link
Contributor Author

mgencur commented Dec 6, 2023

/test reconciler-tests

@mgencur
Copy link
Contributor Author

mgencur commented Dec 6, 2023

Unrelated failure.

/test reconciler-tests

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/test reconciler-tests

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@knative-prow knative-prow bot merged commit fa15023 into knative:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants