chore: refactor cross namespace test to make it reusable #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
size/S
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8157 +/- ##
==========================================
- Coverage 67.71% 67.46% -0.26%
==========================================
Files 370 371 +1
Lines 17946 18001 +55
==========================================
- Hits 12152 12144 -8
- Misses 5020 5085 +65
+ Partials 774 772 -2 ☔ View full report in Codecov by Sentry. |
3 tasks
|
/cc @matzew |
creydr
reviewed
Aug 16, 2024
test/rekt/crossnamespace_test.go
Outdated
| @@ -50,5 +52,7 @@ func TestBrokerTriggerCrossNamespaceReference(t *testing.T) { | |||
| ) | |||
|
|
|||
| // brokerEnv.Test(brokerEnvCtx, t, broker.GoesReady(brokerName)) | |||
| triggerEnv.Test(triggerEnvCtx, t, trigger.CrossNamespaceEventLinks(brokerEnvCtx)) | |||
| triggerEnv.Test(triggerEnvCtx, t, trigger.CrossNamespaceEventLinks(brokerEnvCtx, func(name, namespace string) feature.StepFn { | |||
| return broker.Install(name, broker.WithNamespace(namespace)) | |||
There was a problem hiding this comment.
Is there a reason you didn't reuse broker.GoesReady(name, brokerresources.WithEnvConfig()...)?
Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
size/XS
Signed-off-by: Calum Murray <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the cross namespace test to make the installation of the broker pluggable, enabling the test to be reused in EKB.
Proposed Changes