Scheduler: Resync reserved periodically to keep state consistent

[pierDipi]

Add resyncReserved removes deleted vPods from reserved to keep the state consistent when leadership changes (Promote / Demote).

initReserved is not enough since the vPod lister can be stale.

Fixes #

Proposed Changes

• Resync reserved periodically to keep state consistent

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Docs

[pierDipi]

/cherry-pick release-1.16

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/cherry-pick release-1.17

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (4a6e7d2) to head (4c53339).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/scheduler/statefulset/scheduler.go	62.50%	12 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8451      +/-   ##
==========================================
- Coverage   64.10%   63.91%   -0.19%     
==========================================
  Files         388      391       +3     
  Lines       23363    23543     +180     
==========================================
+ Hits        14976    15048      +72     
- Misses       7591     7691     +100     
- Partials      796      804       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@pierDipi: new pull request created: #8452

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: new pull request created: #8453

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/cherry-pick release-1.15

[knative-prow-robot]

@pierDipi: new pull request created: #8454

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.