Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventTransform: Reconcile address and service #8458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EventTransform: Reconcile address and service #8458

wants to merge 1 commit into from
+346 −47

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 12, 2025 •
edited
Loading

  • Set address only once endpoints are available
  • Add debug logging
  • Fix semantic comparisons to avoid loops

It's now fully working end to end.

Related to:

Proposed Changes

  • Set address only once endpoints are available
  • Add debug logging
  • Fix semantic comparisons to avoid loops

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@pierDipi pierDipi force-pushed the eventtransform-jsonata-reconciler-service branch 2 times, most recently from 07e71d0 to af68e76 Compare February 12, 2025 18:35
@pierDipi
EventTransform: Reconcile address and service
6c32b4a 
- Set address only once endpoints are available
- Add debug logging
- Fix semantic comparisons to avoid loops

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the eventtransform-jsonata-reconciler-service branch from af68e76 to 6c32b4a Compare February 12, 2025 18:48
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 161 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (779992f) to head (6c32b4a).

Files with missing lines Patch % Lines
pkg/reconciler/eventtransform/eventtransform.go 0.00% 96 Missing ⚠️
pkg/reconciler/eventtransform/resources_jsonata.go 0.00% 41 Missing ⚠️
pkg/reconciler/eventtransform/controller.go 0.00% 18 Missing ⚠️
...pis/eventing/v1alpha1/eventtransform_validation.go 0.00% 3 Missing ⚠️
...apis/eventing/v1alpha1/eventtransform_lifecycle.go 0.00% 2 Missing ⚠️
.../apis/eventing/v1alpha1/eventtransform_defaults.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8458      +/-   ##
==========================================
- Coverage   63.02%   62.68%   -0.34%     
==========================================
  Files         394      395       +1     
  Lines       23882    24009     +127     
==========================================
  Hits        15051    15051              
- Misses       8028     8155     +127     
  Partials      803      803

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Feb 13, 2025
Open
Open
Open
creydr
creydr reviewed Feb 13, 2025
View reviewed changes
config/core/deployments/controller.yaml
@@ -77,6 +77,9 @@ spec:
fieldRef:
fieldPath: metadata.name

- name: EVENT_TRANSFORM_JSONATA_IMAGE
value: quay.io/pierdipi/jsonata-transform@sha256:6aafed0012b8a3c24a1cd72fc4521981ec7680cf64988c22ded0aafa2a431c93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a left over, or don't we have yet a built of https://github.com/knative-extensions/eventing-integrations/tree/main/transform-jsonata

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have that, that repo builds only the integration bits (which are also on latest, still in eventing 🙈 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @matzew @creydr