fix: on cluster build - workaround for Tekton issue with empty array #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zroubalik
requested review from
lance,
matejvasek,
jrangelramos and
lkingland
knative-prow
bot
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 45.42% 45.36% -0.06%
==========================================
Files 68 68
Lines 9718 9723 +5
==========================================
- Hits 4414 4411 -3
- Misses 4912 4919 +7
- Partials 392 393 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zroubalik
force-pushed
the
ocbEnvFix
branch
2 times, most recently
from
4609b7c to
71a8d65
Compare
jrangelramos
reviewed
Sep 5, 2022
knative-prow
bot
removed
the
approved
knative-prow
bot
added
the
approved
|
e2e test fails because of issue fixed in #1213 |
lkingland
approved these changes
Sep 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zbynek Roubalik <[email protected]>
|
@lkingland could you please LGTM again, I rebased this and e2e tests are passing. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik [email protected]
Need to hack empty BuildEnvs array on Tekton v0.39.0+ untill tektoncd/pipeline#5149 is resolved and released.
Withouth this change on-cluster-builds fail on Tekton v0.39.0+ if there is not any Build Env specifed.
Changes
/kind bug