Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding oncluster builds e2e tests for s2i supported runtimes #1235

Merged
merged 2 commits into from
Oct 20, 2022
Merged

test: adding oncluster builds e2e tests for s2i supported runtimes #1235

merged 2 commits into from
Oct 20, 2022

Conversation

jrangelramos
Copy link
Contributor

@jrangelramos jrangelramos commented Sep 12, 2022 •
edited
Loading

Changes

/kind cleanup

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022 •
edited
Loading

Codecov Report

Merging #1235 (17d3e96) into main (1ed5b2d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   45.59%   45.62%   +0.03%     
==========================================
  Files          68       68              
  Lines        9809     9809              
==========================================
+ Hits         4472     4475       +3     
+ Misses       4941     4939       -2     
+ Partials      396      395       -1
Impacted Files Coverage Δ
s2i/builder.go 62.24% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jrangelramos
Copy link
Contributor Author

wating for #1234

@jrangelramos jrangelramos force-pushed the s2i-oncluster-tests branch 2 times, most recently from 154ebce to 4b56d9b Compare September 13, 2022 01:14
@jrangelramos jrangelramos marked this pull request as ready for review September 13, 2022 01:15
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
@jrangelramos jrangelramos force-pushed the s2i-oncluster-tests branch 3 times, most recently from 5d3cfd2 to 17d3e96 Compare September 13, 2022 01:25
@jrangelramos jrangelramos marked this pull request as draft September 13, 2022 01:39
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
@jrangelramos
Copy link
Contributor Author

Also fixes #1363

@jrangelramos jrangelramos marked this pull request as ready for review October 19, 2022 19:37
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@jrangelramos
Copy link
Contributor Author

jrangelramos commented Oct 19, 2022 •
edited
Loading

/cc @zroubalik @lance @matejvasek @lkingland

@knative-prow knative-prow bot requested review from lance and zroubalik October 19, 2022 19:41
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 61.99% // Head: 62.23% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (7972002) compared to base (cdfeec5).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   61.99%   62.23%   +0.24%     
==========================================
  Files          74       75       +1     
  Lines       10671    10673       +2     
==========================================
+ Hits         6615     6642      +27     
+ Misses       3498     3473      -25     
  Partials      558      558
Flag Coverage Δ
integration-tests 51.97% <ø> (-0.01%) ⬇️
unit-tests ?
unit-tests-macos-latest 52.19% <ø> (?)
unit-tests-ubuntu-latest 53.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
knative/deployer.go 61.55% <0.00%> (-0.17%) ⬇️
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

zroubalik
zroubalik approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f5470c0 into knative:main Oct 20, 2022
@jrangelramos jrangelramos mentioned this pull request Oct 20, 2022
Closed
@jrangelramos jrangelramos deleted the s2i-oncluster-tests branch October 20, 2022 14:39
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@jrangelramos @lance
test: adding oncluster builds e2e tests for s2i supported runtimes (k…
77bce5b 
…native#1235)

* test: adding oncluster builds e2e tests for s2i supported runtimes

* fix: s2i tekton task with empty build envs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@lance lance Awaiting requested review from lance

Assignees

@zroubalik zroubalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrangelramos @zroubalik @knative-prow-robot