Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for adding support for volume type EmptyDir #11664

Closed
7 tasks done
skonto opened this issue Jul 13, 2021 · 14 comments
Closed
7 tasks done

Tracking issue for adding support for volume type EmptyDir #11664

skonto opened this issue Jul 13, 2021 · 14 comments
Assignees
@skonto
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)

Comments

@skonto
Copy link
Contributor

skonto commented Jul 13, 2021 •
edited
Loading

Describe the feature

This is a placeholder for the feature track work described in the related doc and targets EmptyDir support only:

Alpha (disabled by default):

  • Add volume support for EmptyDir in KService
  • Enable RW access and add e2e test
  • Add to listed flags here.

Beta (enabled by default):

  • Set conformance test for Beta
  • Set on by default

GA (Always on, cant be disabled):

  • Set always on
  • Add Knative CLI support (enhance --volume flag)

/cc @julz @dprotaso @markusthoemmes

Related tickets: #4417
@skonto skonto added the kind/feature Well-understood/specified features, ready for coding. label Jul 13, 2021
@dprotaso
Copy link
Member

dprotaso commented Jul 13, 2021 •
edited
Loading

Add conformance tests

Adding anything to the conformance would require going through the Trademark committee. I have an umbrella issue for that.

@dprotaso dprotaso mentioned this issue Jul 13, 2021
Closed
1 task
@skonto skonto mentioned this issue Jul 13, 2021
Merged
@skonto skonto changed the title Add support for volume type EmptyDir Tracking issue for adding support for volume type EmptyDir Jul 19, 2021
This was referenced Jul 21, 2021
Merged
Merged
@skonto
Copy link
Contributor Author

skonto commented Jul 29, 2021

/assign @skonto

@skonto skonto mentioned this issue Jul 29, 2021
Closed
@dprotaso
Copy link
Member

dprotaso commented Sep 15, 2021 •
edited
Loading

I created a PR knative/specs#72 to relax the conformance spec. Prior it restricted all volumes to be readonly. I've changed the language to defer the requirement to the volume's source.

@skonto skonto mentioned this issue Oct 25, 2021
Merged
@romanwozniak romanwozniak mentioned this issue Jan 19, 2022
Merged
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2022
@rhuss
Copy link
Contributor

rhuss commented Mar 16, 2022

@skonto where do we stand with this issue ? What is still left to be done ?

@skonto
Copy link
Contributor Author

skonto commented Mar 16, 2022 •
edited
Loading

@rhuss As described in the list above we need to finalize the beta phase and then move to GA.
That means first turn on the feature by default with the flag available and at some point remove the flag to reach GA.
We could omit the beta phase final step as the feature is already mature but removing the flag maybe an issue as potential users may dont want to allow that capability in there cluster. I will make the PR and see how this is going to be received by Serving folks.

@rhuss
Copy link
Contributor

rhuss commented Mar 16, 2022

thanks! was just asking to prevent this issue from becoming closed as being stale ;-)

wrt/ to the client support mentioned above: Could you please open an issue over there to work on this support? Not sure if the client has support for volumes at all right now.

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2022
@skonto
Copy link
Contributor Author

skonto commented Mar 16, 2022

Sure will do.

@skonto skonto mentioned this issue Mar 16, 2022
Closed
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2022
@skonto
Copy link
Contributor Author

skonto commented Jun 15, 2022

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2022
@dprotaso
Copy link
Member

dprotaso commented Aug 2, 2022

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Aug 2, 2022
@dprotaso dprotaso mentioned this issue Oct 17, 2022
Merged
@ReToCode
Copy link
Member

I checked the client implementation. Seems like the EmptyDir support is already fully covered:

@skonto. WDYT?

@skonto
Copy link
Contributor Author

skonto commented Jan 17, 2023

Yes it seems the support was added here knative/client#1679

@ReToCode
Copy link
Member

Yeah, so this issue is complete, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skonto skonto

Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dprotaso @rhuss @skonto @ReToCode @knative-prow-robot