Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API specification #10738

Closed
1 task done
dprotaso opened this issue Feb 10, 2021 · 12 comments
Closed
1 task done

Update API specification #10738

dprotaso opened this issue Feb 10, 2021 · 12 comments
Assignees
@dprotaso
Labels
area/API API objects and controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Milestone
0.26.x

Comments

@dprotaso
Copy link
Member

dprotaso commented Feb 10, 2021 •
edited
Loading

Describe the feature

serviceAccount projection was has been added via. #9264

There may be a few more things we've added that isn't reflected in the spec
@dprotaso dprotaso added the kind/feature Well-understood/specified features, ready for coding. label Feb 10, 2021
@dprotaso
Copy link
Member Author

/area API

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Feb 10, 2021
@dprotaso
Copy link
Member Author

/assign @dprotaso

@dprotaso
Copy link
Member Author

dprotaso commented Feb 22, 2021 •
edited
Loading

another - ReadOnlyRootFilesystem #10560

@dprotaso
Copy link
Member Author

dprotaso commented Feb 25, 2021 •
edited
Loading

(future) Container.SecurityContext #9067

@dprotaso
Copy link
Member Author

dprotaso commented Feb 25, 2021 •
edited
Loading

(happening now!) Exposing replica #'s on Revision Status - #10750

@evankanderson
Copy link
Member

/kind cleanup

One question (particularly as trademark/conformance get more active): which fields are "OSS project extensions", and which are core parts of what Knative is. (e.g. the replica numbers might be more "core" than the security contexts.

@knative-prow-robot knative-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 15, 2021
@evankanderson
Copy link
Member

/triage accepted

@knative-prow-robot knative-prow-robot added the triage/accepted Issues which should be fixed (post-triage) label Mar 15, 2021
@dprotaso dprotaso added this to the 0.23.x milestone Apr 6, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Apr 21, 2021 •
edited
Loading

Related: #11170

@evankanderson
Copy link
Member

Note that actualReplicas, etc aren't actually in the spec at all for Revision: https://github.com/knative/specs/blob/main/specs/serving/knative-api-specification-1.0.md#spec-3

@dprotaso dprotaso modified the milestones: 0.23.x, 0.24.x May 25, 2021
@dprotaso dprotaso modified the milestones: 0.24.x, 0.25.x Jul 6, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jul 13, 2021 •
edited
Loading

EmptyDir support: #11664

This makes sure the spec language allows for RW volumes

@skonto
Copy link
Contributor

skonto commented Jul 20, 2021

For emptyDir support we will need to update the spec about RW access (right now we set all volumes to read-only in revision defaults).

@dprotaso dprotaso modified the milestones: 0.25.x, 0.26.x Aug 26, 2021
@dprotaso
Copy link
Member Author

All the spec changes mentioned in this issue have corresponding PRs in knative/specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dprotaso dprotaso

Labels
area/API API objects and controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
0.26.x
Development

No branches or pull requests
4 participants
@dprotaso @skonto @evankanderson @knative-prow-robot