-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Service CRD to conformance tests #591
Comments
Once #597 goes in we should be able to start adding conformance tests. |
@jonjohnsonjr I think you're working on this so I've assigned it to you but feel free to assign it back if that's wrong! |
/kind cleanup Jon, any updates here? |
Very close to having a working happy path, with unhappy paths to follow soon after. I had to actually make it conform before I can land the test, currently waiting on #1330 /cc @mattmoor Something working 👍 will have a PR once I clean this up!
|
I think between what @jonjohnsonjr and @dgerd have added, our conformance test coverage of the Service resource has gotten pretty good. I'm going to close this as done since I feel like most of our gaps lie outside of what I'd consider the scope of this issue. |
…rkload (knative#14568) (knative#591) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
…rkload (knative#14568) (knative#591) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
…rkload (knative#14568) (knative#591) (knative#605) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
Expected Behavior
In #577 we have added a new CRD type which is part of the core Elafros API.
Actual Behavior
This new CRD should be tested in the conformance tests.
Additional Info
Waiting on controller implementation by @vaikas-google and spec/docs from @evankanderson .
The text was updated successfully, but these errors were encountered: