Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-gateway-api nightly #14668

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Nov 24, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-gateway-api.yaml istio-gateway.yaml gateway-api.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-gateway-api/latest/$x > ${GITHUB_WORKSPACE}/./third_party/gateway-api-latest/$x
done

Details:

bumping knative.dev/net-gateway-api 2dff2a7...f9e2ce4:
  > f9e2ce4 upgrade to latest dependencies (# 585)
  > 7b3b24d Update community files (# 586)

@knative-automation knative-automation force-pushed the update-nightly/net-gateway-api branch from 521d3e4 to a74b19c Compare November 24, 2023 11:05
@knative-prow knative-prow bot requested a review from a team November 24, 2023 11:05
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/networking labels Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b0d185) 86.03% compared to head (a74b19c) 86.02%.

❗ Current head a74b19c differs from pull request most recent head 072bc7e. Consider uploading reports for the commit 072bc7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14668      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.02%     
==========================================
  Files         197      197              
  Lines       14937    14937              
==========================================
- Hits        12851    12849       -2     
- Misses       1775     1777       +2     
  Partials      311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bumping knative.dev/net-gateway-api 2dff2a7...f9e2ce4:
  > f9e2ce4 upgrade to latest dependencies (# 585)
  > 7b3b24d Update community files (# 586)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-gateway-api branch from a74b19c to 072bc7e Compare November 27, 2023 11:05
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link

knative-prow bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@knative-prow knative-prow bot merged commit c5a8fa9 into knative:main Nov 28, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants