-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated] Update net-istio nightly #14706
[Automated] Update net-istio nightly #14706
Conversation
209c71e
to
aa50bb4
Compare
/retest |
/hold This needs #14610 to work. |
aa50bb4
to
5d31f8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14706 +/- ##
==========================================
+ Coverage 86.02% 86.04% +0.02%
==========================================
Files 197 197
Lines 14950 14950
==========================================
+ Hits 12860 12864 +4
+ Misses 1777 1775 -2
+ Partials 313 311 -2 ☔ View full report in Codecov by Sentry. |
e4a4b7a
to
4d48cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/unhold |
/hold This still needs #14610 to work. |
4d48cc8
to
c5aa59c
Compare
c5aa59c
to
34544a6
Compare
8125391
to
09e0539
Compare
24439ae
to
1d49f67
Compare
1d49f67
to
c177d51
Compare
bumping knative.dev/net-istio ca16070...04509ce: > 04509ce Add K8s 1.29 testing and bump github actions (# 1241) > c57f453 Update community files (# 1242) > a5b1f5c upgrade to latest dependencies (# 1236) > 34c78f0 Update community files (# 1235) > fbee9c0 Replace deprecated sets usages with generic version (# 1234) > f87389c upgrade to latest dependencies (# 1233) > 5db6d0f Update community files (# 1232) > 373ba92 Update community files (# 1230) > d0708dd upgrade to latest dependencies (# 1231) > fadb996 upgrade to latest dependencies (# 1229) > 4af3076 upgrade to latest dependencies (# 1225) > 6899886 Use ko label filter instead of removing KnativeCertificate yaml (# 1224) > e6e6cb7 Update net-istio to use `KnativeCertificate` instead of control-protocol secret (# 1221) > b3007f4 upgrade to latest dependencies (# 1223) Signed-off-by: Knative Automation <[email protected]>
c177d51
to
3bd8681
Compare
Want to unblock this PR - so I've disabled the system internal tls tests for Istio |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-automation, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55b0293
to
a08915c
Compare
/hold cancel |
/retest |
weird - istio-tls jobs are failing |
/retest |
/lgtm |
Going to disable that as well - since it requires system-internal-tls |
* use Knative certificates for Serving encryption * Make namespace the owner of the Queue-Proxy certificate * Lint error fixes * Minor fixes * cherry-pick #14706 * keep existing secret in upgrade/downgrade tests * Rebase and update to upstream/main * Review improvements * Update net-istio * Use a revision tracker to reconcile on KCerts
/assign @knative/serving-writers
/cc @knative/serving-writers
Produced via:
Details: